Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate unused logger method #1144

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Deprecate unused logger method #1144

merged 1 commit into from
Dec 10, 2021

Conversation

chuailiwu
Copy link
Collaborator

Motivation:

Deprecate unused logger method (with appname)

@sofastack-bot sofastack-bot bot added cla:yes CLA is ok size/S labels Dec 10, 2021
@Lihus
Copy link

Lihus commented Dec 10, 2021 via email

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #1144 (9a53f13) into master (7b3b402) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1144      +/-   ##
============================================
+ Coverage     70.94%   71.01%   +0.06%     
  Complexity      829      829              
============================================
  Files           405      405              
  Lines         17108    17106       -2     
  Branches       2670     2670              
============================================
+ Hits          12137    12147      +10     
+ Misses         3587     3577      -10     
+ Partials       1384     1382       -2     
Impacted Files Coverage Δ
.../com/alipay/sofa/rpc/log/MiddlewareLoggerImpl.java 79.10% <ø> (+2.29%) ⬆️
...va/com/alipay/sofa/rpc/client/AbstractCluster.java 69.37% <0.00%> (-0.27%) ⬇️
...ipay/sofa/rpc/tracer/sofatracer/RpcSofaTracer.java 91.06% <0.00%> (+0.74%) ⬆️
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java 86.79% <0.00%> (+1.88%) ⬆️
...ipay/sofa/rpc/server/bolt/BoltServerProcessor.java 69.59% <0.00%> (+4.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b3b402...9a53f13. Read the comment docs.

Copy link
Contributor

@OrezzerO OrezzerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chuailiwu chuailiwu merged commit 02803d7 into master Dec 10, 2021
@EvenLjj EvenLjj deleted the fix/logger branch May 7, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants