Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config recursive type bound problem and typos #1107

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Fix config recursive type bound problem and typos #1107

merged 1 commit into from
Oct 8, 2021

Conversation

alaneuler
Copy link
Contributor

No description provided.

@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes CLA is ok size/S labels Oct 8, 2021
Copy link
Contributor

@leizhiyuan leizhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #1107 (f190301) into master (2e571f0) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1107      +/-   ##
============================================
- Coverage     69.15%   69.06%   -0.10%     
  Complexity      828      828              
============================================
  Files           409      409              
  Lines         17721    17721              
  Branches       2749     2749              
============================================
- Hits          12255    12239      -16     
- Misses         4059     4067       +8     
- Partials       1407     1415       +8     
Impacted Files Coverage Δ
...a/com/alipay/sofa/rpc/config/AbstractIdConfig.java 92.30% <100.00%> (ø)
...lipay/sofa/rpc/config/AbstractInterfaceConfig.java 52.71% <100.00%> (ø)
...java/com/alipay/sofa/rpc/module/LookoutModule.java 52.38% <0.00%> (-33.34%) ⬇️
...rpc/interceptor/ClientHeaderClientInterceptor.java 71.87% <0.00%> (-15.63%) ⬇️
...fa/rpc/interceptor/ServerReqHeaderInterceptor.java 80.32% <0.00%> (-9.84%) ⬇️
...om/alipay/sofa/rpc/metrics/lookout/RpcLookout.java 80.95% <0.00%> (+0.95%) ⬆️
.../alipay/sofa/rpc/metrics/lookout/RpcLookoutId.java 88.88% <0.00%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e571f0...f190301. Read the comment docs.

Copy link
Contributor

@OrezzerO OrezzerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alaneuler alaneuler merged commit 8bc1c7a into sofastack:master Oct 8, 2021
@EvenLjj EvenLjj added this to the 5.8.0 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes CLA is ok size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants