Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get wrong ProviderInfo when use reuses client transport. #101

Merged
merged 1 commit into from
May 9, 2018

Conversation

ujjboy
Copy link
Member

@ujjboy ujjboy commented May 9, 2018

Motivation:

When reuse client transport, the invoke event should not get consumer config and provider info from client transport self but from context.

Modification:

  • Add InterfaceConfig to RpcInternalContext
  • Use RpcInternalContext.getInterfaceConfig() instead of transport.getInterfaceConfig()
  • Use RpcInternalContext.getProviderInfo() instead of transport.getProviderInfo()
  • Add event to RestClientTransport

Result:

Fixes #99 in v5.3.x

@ujjboy ujjboy added the bug Something isn't working label May 9, 2018
@ujjboy ujjboy added this to the 5.3.3 milestone May 9, 2018
@codecov-io
Copy link

Codecov Report

Merging #101 into 5.3 will increase coverage by 0.02%.
The diff coverage is 77.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##                5.3     #101      +/-   ##
============================================
+ Coverage     63.51%   63.53%   +0.02%     
+ Complexity      585      584       -1     
============================================
  Files           263      263              
  Lines         11228    11247      +19     
  Branches       1872     1874       +2     
============================================
+ Hits           7131     7146      +15     
+ Misses         3135     3131       -4     
- Partials        962      970       +8
Impacted Files Coverage Δ Complexity Δ
...y/sofa/rpc/transport/rest/RestClientTransport.java 100% <ø> (+10%) 3 <0> (-1) ⬇️
...ipay/sofa/rpc/server/bolt/BoltServerProcessor.java 64.51% <100%> (+0.28%) 20 <0> (ø) ⬇️
...va/com/alipay/sofa/rpc/client/AbstractCluster.java 64.66% <100%> (+0.23%) 0 <0> (ø) ⬇️
...fa/rpc/transport/AbstractProxyClientTransport.java 59.75% <57.14%> (-0.81%) 0 <0> (ø)
...y/sofa/rpc/transport/bolt/BoltClientTransport.java 66.24% <85.71%> (-0.21%) 27 <2> (ø)
...om/alipay/sofa/rpc/context/RpcInternalContext.java 62.6% <87.5%> (+7.65%) 0 <0> (ø) ⬇️
...pay/sofa/rpc/transport/ClientTransportFactory.java 60.6% <0%> (-4.55%) 0% <0%> (ø)
...ent/aft/impl/ServiceHorizontalMeasureStrategy.java 83.65% <0%> (-2.89%) 22% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d54cfe...e96bfbb. Read the comment docs.

@ujjboy ujjboy merged commit 4bd9097 into sofastack:5.3 May 9, 2018
@ujjboy ujjboy deleted the fix_issue_99 branch May 9, 2018 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants