Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

Hystrix switcher #137

Merged
merged 5 commits into from
Dec 29, 2018
Merged

Hystrix switcher #137

merged 5 commits into from
Dec 29, 2018

Conversation

leizhiyuan
Copy link
Contributor

Motivation:

Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.

Modification:

#135

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

@@ -118,6 +118,8 @@

private String consumerRepeatedReferenceLimit;

private String enableHystrix;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does enableHystrix means the key is com.alipay.sofa.rpc.enable.hystrix ?

I think com.alipay.sofa.rpc.hystrix.enable is better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be com.alipay.sofa.rpc.enable-hystrix=true

@leizhiyuan leizhiyuan added this to the 5.5.0 milestone Dec 18, 2018
@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

Merging #137 into 5.x will increase coverage by 0.37%.
The diff coverage is 37.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##                5.x    #137      +/-   ##
===========================================
+ Coverage     55.23%   55.6%   +0.37%     
- Complexity      400     404       +4     
===========================================
  Files            56      56              
  Lines          1778    1784       +6     
  Branches        314     315       +1     
===========================================
+ Hits            982     992      +10     
+ Misses          608     605       -3     
+ Partials        188     187       -1
Impacted Files Coverage Δ Complexity Δ
...ay/sofa/rpc/boot/config/SofaBootRpcProperties.java 55.72% <25%> (-0.63%) 88 <1> (+1)
...t/runtime/adapter/helper/ConsumerConfigHelper.java 54.05% <25%> (-1%) 14 <0> (ø)
...t/runtime/adapter/helper/ProviderConfigHelper.java 45.33% <50%> (ø) 5 <0> (ø) ⬇️
...y/sofa/rpc/boot/runtime/param/RpcBindingParam.java 39.28% <50%> (ø) 43 <1> (ø) ⬇️
...sofa/rpc/boot/container/ServerConfigContainer.java 82.82% <0%> (+4.54%) 44% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 555ac55...84c62e2. Read the comment docs.

@JervyShi JervyShi merged commit dfe71b6 into sofastack:5.x Dec 29, 2018
leizhiyuan added a commit that referenced this pull request Mar 8, 2019
* Consul registry support (#126)

* consul registry support

* fix cr

* Support nacos converter (#130)

* Upgrade version

* Support nacos address converter

* Hystrix switcher (#137)

* support enableHystrix

* support enableHystrix

* hystrix enable

* Add nacos client dependency support. (#148)

* Zk auth support. (#156)

* Server config for rest cors. (#155)

* server config for rest cors

* add test case for cors
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants