This repository has been archived by the owner on May 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 13, 2018
ujjboy
suggested changes
Dec 14, 2018
@@ -118,6 +118,8 @@ | |||
|
|||
private String consumerRepeatedReferenceLimit; | |||
|
|||
private String enableHystrix; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does enableHystrix
means the key is com.alipay.sofa.rpc.enable.hystrix
?
I think com.alipay.sofa.rpc.hystrix.enable
is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be com.alipay.sofa.rpc.enable-hystrix=true
JervyShi
approved these changes
Dec 29, 2018
NeGnail
approved these changes
Dec 29, 2018
Codecov Report
@@ Coverage Diff @@
## 5.x #137 +/- ##
===========================================
+ Coverage 55.23% 55.6% +0.37%
- Complexity 400 404 +4
===========================================
Files 56 56
Lines 1778 1784 +6
Branches 314 315 +1
===========================================
+ Hits 982 992 +10
+ Misses 608 605 -3
+ Partials 188 187 -1
Continue to review full report at Codecov.
|
ujjboy
approved these changes
Dec 29, 2018
ujjboy
approved these changes
Dec 29, 2018
leizhiyuan
added a commit
that referenced
this pull request
Mar 8, 2019
* Consul registry support (#126) * consul registry support * fix cr * Support nacos converter (#130) * Upgrade version * Support nacos address converter * Hystrix switcher (#137) * support enableHystrix * support enableHystrix * hystrix enable * Add nacos client dependency support. (#148) * Zk auth support. (#156) * Server config for rest cors. (#155) * server config for rest cors * add test case for cors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.
Modification:
#135
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.