Fix database creation for GTDB r214 #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@apcamargo Thanks for opening this PR. In order for this code to work, I think one more change is also needed, in line 139 ( Current code: Revised: Mind making this change as well? Thanks! |
|
Done! |
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #740, the protein FASTA files in GTDB r214 are now individually compressed. Because the
mmseqs tar2dbcommand only includes files that finish wirh.faa, the protein files are being ignored and the database is not being created.This PR just changes this line to change
--tar-include 'faa$'to--tar-include 'faa.gz$'.