Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move polars to version 1, fix test errors, rerun examples #299

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Move polars to version 1, fix test errors, rerun examples #299

merged 1 commit into from
Jul 12, 2024

Conversation

vankesteren
Copy link
Member

No description provided.

@vankesteren vankesteren requested a review from qubixes July 11, 2024 10:28
qubixes
qubixes approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@qubixes qubixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I suppose with too many samples, even though the uniform distribution should still be favored, it will be closer and closer to choosing the multinomial distribution?

@vankesteren
Copy link
Member Author

Exactly!

@vankesteren vankesteren merged commit 609ee88 into main Jul 12, 2024
7 checks passed
@vankesteren vankesteren deleted the fix-test-error branch July 12, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qubixes qubixes qubixes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vankesteren @qubixes