Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set information criterion for NA distribution high #298

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Conversation

qubixes
Copy link
Member

@qubixes qubixes commented Jul 2, 2024

Not setting a high IC for the NA distribution causes the NA distribution to be selected for the disclosure control plugin (since there is not regex model). This PR should fix that.

There might be some more discussion to be had on the relative IC's for the static type of distributions, but I think for now, we should never select the NA distribution unless they're all NA's (or no other distributions are available).

@qubixes qubixes requested a review from vankesteren July 2, 2024 07:50
@qubixes
Copy link
Member Author

qubixes commented Jul 17, 2024

@vankesteren Shall I just merge it?

@vankesteren
Copy link
Member

Yes!

@qubixes qubixes merged commit 7bd6a0a into main Aug 7, 2024
6 of 7 checks passed
@qubixes qubixes deleted the fix-na-ic branch August 8, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants