Example

[jgarciab]

Improved examples and README

[jgarciab]

Please @modhurita review, and add yourself to the citation, once we have a new version we can put it in Zenodo and add your name there too

[modhurita]

Is it not confusing to first say that geckodriver needs to be installed, and then say that it is installed automatically? Maybe it is better to leave out any mention of geckodriver?

[jgarciab]

Yes let's remove geckodriver

[modhurita]

Cell 5 is empty and needs to be removed.

[jgarciab]

Yes please

[modhurita]

Hi @jgarciab :

Thanks for your work on improving this repository!

I have provided some comments above, and changed some things myself online. I hope they look okay to you.

I could run the Google Arts & Culture parts of the example notebooks, but not the WikiArt ones. I obtained API keys by creating a WikiArt account, and placed them in the examples directory, as per the instructions in the README. However, the very first example cell didn't execute successfully. This is the error I got:

FileNotFoundError                         Traceback (most recent call last)
~/ResearchEngineering/artscraper/artscraper/wikiart.py in __init__(self, output_dir, skip_existing, min_wait, timeout)
     23         try:
---> 24             with open(".wiki_session", "r", encoding="utf-8") as f:
     25                 self.session_key = f.read()

FileNotFoundError: [Errno 2] No such file or directory: '.wiki_session'

During handling of the above exception, another exception occurred:

KeyError                                  Traceback (most recent call last)
/tmp/ipykernel_13612/1175252453.py in <module>
      3 art_url = "https://www.wikiart.org/en/edvard-munch/anxiety-1894"
      4 
----> 5 with WikiArtScraper() as scraper:
      6     scraper.load_link(art_url)
      7     metadata = scraper.get_metadata()

~/ResearchEngineering/artscraper/artscraper/wikiart.py in __init__(self, output_dir, skip_existing, min_wait, timeout)
     25                 self.session_key = f.read()
     26         except FileNotFoundError:
---> 27             self._new_session()
     28             with open(".wiki_session", "w", encoding="utf-8") as f:
     29                 f.write(self.session_key)

~/ResearchEngineering/artscraper/artscraper/wikiart.py in _new_session(self)
     66                                 },
     67                                 timeout=self.timeout)
---> 68         self.session_key = json.loads(response.text)["SessionKey"]
     69         self.last_request = time.time()
     70 

KeyError: 'SessionKey'

Finally, at which position in the names list in the citation should I add my name?

Thanks,
Modhurita

[jgarciab]

Hi Modhurita, I only tried with the interactive version, could you try to figure it out? That was Raoul's part, if you don't understand it how it works maybe you could ask him.

You can add your name in second place in the citation if you are okay with that.

[modhurita]

Hi @jgarciab :

The WikiArt part seems to work now - not sure why I got that error earlier. I have made the other changes. I approve the pull request; you can now merge this branch into main now.