Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Powerstore storage #970

Merged
merged 6 commits into from
Jan 9, 2023
Merged

add Powerstore storage #970

merged 6 commits into from
Jan 9, 2023

Conversation

zhilong-xu
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #970 (7e50a5e) into master (2538007) will increase coverage by 0.36%.
The diff coverage is 82.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #970      +/-   ##
==========================================
+ Coverage   70.49%   70.85%   +0.36%     
==========================================
  Files         192      195       +3     
  Lines       23237    23987     +750     
  Branches     3571     3674     +103     
==========================================
+ Hits        16380    16997     +617     
- Misses       5734     5826      +92     
- Partials     1123     1164      +41     
Impacted Files Coverage Δ
...elfin/drivers/dell_emc/power_store/rest_handler.py 79.13% <79.13%> (ø)
delfin/drivers/dell_emc/power_store/power_store.py 89.15% <89.15%> (ø)
delfin/common/constants.py 100.00% <100.00%> (ø)
delfin/drivers/dell_emc/power_store/consts.py 100.00% <100.00%> (ø)
delfin/drivers/fake_storage/__init__.py 93.54% <0.00%> (-0.78%) ⬇️

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisererik wisererik merged commit e0290fd into sodafoundation:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants