Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsp change device_model method #933

Merged
merged 4 commits into from
Oct 28, 2022
Merged

Conversation

tanjiangyu-ghca
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #933 (d25b919) into master (996ff13) will increase coverage by 0.00%.
The diff coverage is 57.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #933   +/-   ##
=======================================
  Coverage   71.51%   71.51%           
=======================================
  Files         181      181           
  Lines       21925    21925           
  Branches     3333     3333           
=======================================
+ Hits        15679    15680    +1     
- Misses       5175     5176    +1     
+ Partials     1071     1069    -2     
Impacted Files Coverage Δ
delfin/drivers/hitachi/vsp/rest_handler.py 39.39% <57.14%> (-1.02%) ⬇️
delfin/drivers/fake_storage/__init__.py 95.17% <0.00%> (+0.76%) ⬆️

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisererik wisererik merged commit ddcdd27 into sodafoundation:master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants