Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pure metrics #911

Merged
merged 10 commits into from
Jun 27, 2022
Merged

Pure metrics #911

merged 10 commits into from
Jun 27, 2022

Conversation

zhilong-xu
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #911 (3957d42) into master (bfd1318) will increase coverage by 0.11%.
The diff coverage is 88.97%.

@@            Coverage Diff             @@
##           master     #911      +/-   ##
==========================================
+ Coverage   71.35%   71.47%   +0.11%     
==========================================
  Files         182      182              
  Lines       21400    21532     +132     
  Branches     3271     3291      +20     
==========================================
+ Hits        15269    15389     +120     
- Misses       5097     5103       +6     
- Partials     1034     1040       +6     
Impacted Files Coverage Δ
delfin/drivers/pure/flasharray/pure_flasharray.py 86.20% <88.37%> (+0.66%) ⬆️
delfin/drivers/pure/flasharray/consts.py 100.00% <100.00%> (ø)
delfin/drivers/pure/flasharray/rest_handler.py 40.24% <100.00%> (+1.49%) ⬆️
delfin/drivers/fake_storage/__init__.py 94.41% <0.00%> (+0.76%) ⬆️

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseph-v joseph-v merged commit 0e3e740 into sodafoundation:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants