Emc vnx block add host mapping view #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add host maping view
Add host maping view
Codecov Report
@@ Coverage Diff @@
## master #807 +/- ##
==========================================
+ Coverage 70.47% 70.50% +0.02%
==========================================
Files 181 181
Lines 19055 19232 +177
Branches 2812 2854 +42
==========================================
+ Hits 13429 13559 +130
- Misses 4756 4782 +26
- Partials 870 891 +21
|
joseph-v
reviewed
Jan 21, 2022
| view_model.get('native_masking_view_id'), | ||
| host_id, lun_id) | ||
| views_list.append(view_model) | ||
| elif lun_ids: |
There was a problem hiding this comment.
Masking view without native_storage_host_group_id or native_storage_host_id is invalid. Please check comment section in function list_masking_views() in file <>/delfin/drivers/driver.py
| view_model.get('native_masking_view_id'), | ||
| lun_id) | ||
| views_list.append(view_model) | ||
| elif host_names: |
There was a problem hiding this comment.
Same as above, masking view require native_volume_group_id or native_volume_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
1 add host mapping view
Which issue this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note: