Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test cases for block volume group #1300

Merged
merged 2 commits into from
Sep 10, 2020

Conversation

nguptaopensds
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind new feature

/kind bug fix

/kind cleanup
/kind revert change
/kind design
/kind documentation

/kind enhancement

What this PR does / why we need it:
Unit test for block volume group

Which issue(s) this PR fixes:
#1270

Fixes #

Test Report Added?:

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind TESTED

/kind NOT-TESTED

Test Report:

Special notes for your reviewer:

@codecov-commenter
Copy link

Codecov Report

Merging #1300 into master will increase coverage by 0.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1300      +/-   ##
==========================================
+ Coverage   40.86%   41.25%   +0.38%     
==========================================
  Files          53       53              
  Lines        7752     7752              
==========================================
+ Hits         3168     3198      +30     
+ Misses       4083     4042      -41     
- Partials      501      512      +11     
Impacted Files Coverage Δ
pkg/api/controllers/volumeGroup.go 31.05% <0.00%> (+18.63%) ⬆️

Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comments..which are sim

pkg/api/controllers/volumeGroup_test.go Outdated Show resolved Hide resolved
Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumarashit kumarashit merged commit 7eb8236 into sodafoundation:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants