fix request and response can be string and default value in not a fac… #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMontagu
force-pushed
the
fix/missingEdgeCase
branch
from
b74021d
to
3f34d36
Compare
legau
reviewed
Mar 12, 2024
Comment on lines
559
to
563
| grpc_ation = GRPCAction( | ||
| function=fake_func, | ||
| ) | ||
|
|
||
| self.assertEqual(grpc_ation.function, fake_func) |
There was a problem hiding this comment.
Suggested change
| grpc_ation = GRPCAction( | |
| function=fake_func, | |
| ) | |
| self.assertEqual(grpc_ation.function, fake_func) | |
| grpc_action = GRPCAction( | |
| function=fake_func, | |
| ) | |
| self.assertEqual(grpc_action.function, fake_func) |
…tory for use_generation_plugin_factory
AMontagu
force-pushed
the
fix/missingEdgeCase
branch
from
3f34d36
to
76944af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tory for use_generation_plugin_factory