Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(src/cli/cli.cc): fixes for build and run commands #740

Merged
merged 3 commits into from
Oct 31, 2023
Merged

fix(src/cli/cli.cc): fixes for build and run commands #740

merged 3 commits into from
Oct 31, 2023

Conversation

chicoxyzzy
Copy link
Member

Fixes:

  • add --port and --host as valid flags
  • remove --stdin (not implemented)
  • remove flag duplicates from build command (those that are already in the run)
  • fixes for help output and CLI.md

@chicoxyzzy chicoxyzzy requested review from jwerle and heapwolf and removed request for jwerle October 31, 2023 15:05
@chicoxyzzy chicoxyzzy self-assigned this Oct 31, 2023
@chicoxyzzy chicoxyzzy requested a review from jwerle October 31, 2023 15:05
@chicoxyzzy chicoxyzzy added bug Something isn't working documentation Improvements or additions to documentation cli labels Oct 31, 2023
@chicoxyzzy chicoxyzzy merged commit e2fb315 into master Oct 31, 2023
3 of 8 checks passed
@chicoxyzzy chicoxyzzy deleted the cli_build_n_run_fixes branch October 31, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwerle jwerle jwerle approved these changes

@heapwolf heapwolf Awaiting requested review from heapwolf

Assignees

@chicoxyzzy chicoxyzzy

Labels
bug Something isn't working cli documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chicoxyzzy @jwerle