Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Fiber::Scheduler#blocking_operation_wait. #352

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Nov 6, 2024

This is a very basic implementation of the Fiber::Scheduler#blocking_operation_wait hook.

See https://bugs.ruby-lang.org/issues/20876 for more context.

Types of Changes

  • New feature.

Contribution

@ioquatix ioquatix force-pushed the scheduler-blocking_operation_wait branch 3 times, most recently from 669cf4c to d4af544 Compare November 9, 2024 00:47
@ioquatix ioquatix force-pushed the scheduler-blocking_operation_wait branch from d4af544 to 2217b1a Compare November 20, 2024 07:49
@ioquatix ioquatix force-pushed the scheduler-blocking_operation_wait branch from 7477c21 to 4b0ff84 Compare November 20, 2024 09:49
@ioquatix
Copy link
Member Author

Confirmed tests passing on ruby-head.

@ioquatix ioquatix merged commit c317990 into main Nov 21, 2024
52 of 58 checks passed
@ioquatix ioquatix deleted the scheduler-blocking_operation_wait branch November 21, 2024 00:59
@tenderlove
Copy link

Does this mean that every time something releases the GVL, async will create a new thread?

@ioquatix
Copy link
Member Author

Yes the current implementation is a bit naive. I’ll implement a thread pool if it makes sense to do so. The overhead of thread creation isn’t so bad though - will need to spend some time testing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants