Stop leaking Redis channels on client disconnect #665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions and closed client hashes. Call onDisconnect with local=true for the process that owns the client so that it disconnects from the message: and disconnect: channels for that client.
|
I think this should probably be handled inside onDisconnect. |
|
Do you mean do the publish in onDisconnect if the disconnect is local? If so, what is your reasoning? |
|
Thanks. Your patch was super helpful in tracking down the issue. |
darrachequesne
pushed a commit
that referenced
this pull request
Jul 8, 2024
Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.15.0 to 4.16.6. - [Release notes](https://github.com/browserslist/browserslist/releases) - [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md) - [Commits](browserslist/browserslist@4.15.0...4.16.6) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
darrachequesne
pushed a commit
that referenced
this pull request
Jul 8, 2024
Bumps [qs](https://github.com/ljharb/qs) to 6.11.0 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together. Updates `qs` from 6.7.0 to 6.11.0 - [Release notes](https://github.com/ljharb/qs/releases) - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.7.0...v6.11.0) Updates `express` from 4.17.1 to 4.18.2 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.17.1...4.18.2) --- updated-dependencies: - dependency-name: qs dependency-type: indirect - dependency-name: express dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #663. I don't completely understand the dispatch/closed client buffering stuff, so please check me on this, but we definitely want to send a 'disconnect' mesage to the other processes so that they can close the 'dispatch:id' subscriptions that they opened while processing the 'close' message.
Also, it looks like the original intent was to call onDisconnect with local=true for the process that was actually connected, so that it closes its 'message:id'' and 'disconnect:id' subscriptions.
So with this change we leak 0 Redis channels (instead of 3), and clean up this.closed.