Npm audit changes to fix engine.io vulnerability CVE-2022-21676 #4262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamszegedi thanks a lot 👍 |
|
@darrachequesne Do you recommend that users do 'npm audit fix' on their v4.4.1 installed versions of socket.io to get the updated engine.io, or should we wait for the next release of socket.io containing the updated version? |
|
@ericmandel yes, |
|
Thanks, I just needed to know that the updated engine.io could be dropped in without code changes elsewhere in socket.io ... |
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
New behavior
Other information (e.g. related issues)
Runned npm audit fix in order to update the engine.io dependency version. The new version fixes the vulnerability CVE-2022-21676