Static #391
Merged
Static #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for custom socket.io files based on path structure For example socket.io+websocket+xhr-polling.js will create a dedicated build with only support for websockets and xhr-polling.
|
Related pull request on socket.io-client: socketio/socket.io-client#241 It fixes the dependencies for the jsonp-polling. |
|
+1 sounds good :) |
rauchg
added a commit
that referenced
this pull request
Sep 7, 2011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New static internals for Socket.IO
This is a complete rewrite of the old static functions that where in the
managermodule. This rewrite now builds thesocket.io.jsfile based on the enabled transport types on the server. So by default it will now also strip all the flash related javascript code from the file until you enable it manually.In addition to this there is support to create your own bundle of socket.io transports based on URL parameters. This might be useful for mobile applications as they probably don't need HTMLFile or WebSockets. But your desktop version does. Using
/socket.io+websocket.jswill file that only contains all code for websocket support. You can add more transports by append+<transportname>to the path.Also new in this build is support for GZIP. When we first build up our cache we spawn a gzip process and pipe the data to it, if it's successful we will store it in our cache.
I also extracted the test cases from the
manager.test.jstostatic.test.jswhich now features a total 19 tests for static content.Feedback & pulls are more than welcome ;)