New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop modifying socket id on server side #2506

Closed

tw0517tw wants to merge 1 commit into socketio:master from tw0517tw:patch-1

Contributor

tw0517tw commented Apr 1, 2016

should fix break since b73d9be
#2451 #2405 #2475 #2491

but this could be another breaking change, I'm not sure what will this affect to those who parse nsp name from server side id.


          stop modifying socket id on server side

93c81d7

Contributor Author

tw0517tw commented Apr 1, 2016

fixing tests, close for now.

tw0517tw closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet