Websocket: Accept a PONG #1026
Merged
Websocket: Accept a PONG #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmatthewsr thanks a lot for the patch. Have you tried socket.io master on IE10? We switched to the |
|
Cool. We may not move from 0.9.6 for a bit, but will for sure respond with any issues. Note that I found an issue with ws crashing due to socket errors under certain conditions: websockets/ws#105. Thanks for the quick response. |
|
@jmatthewsr-ms ok, in any case we still need to iron out a few bugs with the |
simonratner
added a commit
to simonratner/socket.io
that referenced
this pull request
Apr 22, 2014
Based on socketio#1026, but extended to cover older protocol versions.
simonratner
added a commit
to simonratner/socket.io
that referenced
this pull request
Apr 22, 2014
Based on socketio#1026, but extended to cover older protocol versions.
simonratner
added a commit
to simonratner/socket.io
that referenced
this pull request
Apr 22, 2014
Based on socketio#1026, extended to cover both protocol versions.
simonratner
added a commit
to simonratner/socket.io
that referenced
this pull request
Apr 23, 2014
Based on socketio#1026, extended to cover both protocol versions.
darrachequesne
added a commit
that referenced
this pull request
Jul 4, 2024
- component-emitter to version 1.2.1 - debug to version 2.3.3 - engine.io-client to version 1.8.0 - parseuri to version 0.0.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For review, it doesn't appear that the current websocket implementation will accept a PONG. IE10 is sending them every 30sec and closing the socket.io connection.
Also, IE10 sets the Mask bit and includes a masking-key, even though there is no data. Be tolerant of this case.
Thanks.