Node v4.0.0 - Build failing #2228
Comments
|
I had this issue and this ticket started 21 days ago solved it for me RamIdeas commented 5 days ago socket.io currently references engine.io#f3fd4bb so upgrading to engine.io#385863d should do the job Edit: Sorry, I've just realised that merged pull request is in a forked repo. But, I can confirm, changing the dependency (in "node_modules/socket.io/package.json") from "engine.io": "1.5.2" to "engine.io": "gsklee/engine.io#385863d" and then running npm install --production from within "node_modules/socket.io" does the trick to get this working on iojs 3.x |
|
@StevenDStanton That workaround "works", but is not very practical. I can't really apply that patch in CI or deployment. |
|
@ owners Can this please be resolved and a new version released? This is causing karma users a lot of pain. |
|
A fix in the next version would be nice 👍 |
|
The issue is resolved in engine.io 1.5.3 (socketio/engine.io#341 (comment)). However, if you update socket.io to use engine.io v1.5.3, there are 4 tests that fail (even on node 0.12). It appears that the API changes in ws 0.7->0.8 didn't affect engine.io's tests but have affected socket.io's tests. womp! EDIT: sorry, there are only 4 failing tests on node 0.12 (https://travis-ci.org/socketio/socket.io/jobs/79534478) Opened a PR so folks could see the test failures - https://travis-ci.org/socketio/socket.io/builds/79534473 |
|
@SpainTrain thanks for the update. I see a few tests failing on engine.io as well with Node 0.4 now. Looking into it. |
|
👍 to get updates |
|
@frankleng To get updates you should click the Subscribe button instead of spamming every person already subscribed to this bug. |
Sorry for contributing to spam comments, but this is a great chance to evangelize the petition that seeks to fix this GH UX fail - https://www.change.org/p/github-inc-add-voting-functionality-for-github-issues There is also isaacs/github#9 for general discussion. |
|
We are listing Node v4.0 issues in this thread. If you find any other issues, please write the issue and add the following url. |
|
Adding to the list: nodejs/node#2798. |
|
Does someone have a solution ? |
|
@maxime1992 a solution is currently:
Thanks to @StevenDStanton for that solution (is also the first answer in this post) |
|
is there some reason this isn't on npm yet? |
|
@StevenDStanton & @KapuzenSohn Thanks, it worked like a charm 👍 |
|
+1 for @StevenDStanton's solution reposted by @KapuzenSohn. It's worth noting that Vouche for consideration of implementation into the main branch. Users of the package should not have to shrinkwrap or modify a project's |
Suggested workaround from socketio/socket.io#2228 (comment)
|
@thuutin Good looks. Is there an ETA on when the master repo will have the fix for the most recent version of Socket.io? |
|
I have started looking for an alternate to socket.io. When such a serious bug with such a simple fix is ignored for so long it shows the maintainers of the software have either abandoned the project or lost interest in it |
@StevenDStanton did you perhaps find any, and would you mind sharing? Thanks. |
|
@StevenDStanton totally agree. |
|
A project as big as socket.io (in terms of other modules and frameworks that depend on it) would really need a bigger team (and funding). Of course one can see that develpers can't always respond in time, but that even stuff like |
|
This error has been caused only by a simple optional dependency as explained here: websockets/ws#586 |
|
There is a huge problem with that. If switching dependencies to a
|
|
@StevenDStanton is my understanding correct that issue is that maintainers can't update NPM and release a new minor version with the trivial fix that has already been merged? So issue is not that nobody can fix the code, but that people who are in control of the project are currently inactive and can't do trivial NPM package update? That is the situation? |
|
@Restuta Correct |
|
@torvalamo I thought the process is automated as soon as you merge something to some branch like |
Doesn't appear to be in the travis file https://github.com/socketio/socket.io/blob/master/.travis.yml (would look like http://docs.travis-ci.com/user/deployment/npm/)
If this is the case, the folks that run the npm registry have processes to handle these situations - https://docs.npmjs.com/misc/disputes |
@rauchg why are we still waiting for this? |
I don't think it's fixed; |
|
Yes. With path:
|
|
1.3.7 out! Thanks for the patience <3 — On Mon, Sep 21, 2015 at 2:57 AM Сковорода Никита Андреевич <
|
|
This is the output you should now be getting ☯ ~ npm install socket.io
CXX(target) Release/obj.target/bufferutil/src/bufferutil.o
CXX(target) Release/obj.target/validation/src/validation.o
CXX(target) Release/obj.target/bufferutil/src/bufferutil.o
CXX(target) Release/obj.target/validation/src/validation.o On Mon, Sep 21, 2015 at 4:33 AM Guillermo Rauch [email protected] wrote:
|
|
Thanks @rauchg! |
|
Building perfectly for me with Xcode 7 and Node.js 4.1 on OS X 10.11. Thanks @rauchg. <3 |
|
Works on Windows too. Thanks @rauchg |
|
Node 4 should also be added to .travis.yml. |
|
Working fine with Node.js 4.1 on Ubuntu 14.04. Thanks @rauchg |
and others
When installing socket.io latest with node V4.0.0 (stable), the following build failure occurs.
This is obviously a compilation problem with upstream packages on
utf-8-validateandbufferutil, never-the-less a release will need to be made with their subsequent releases.I will be adding tickets in these two projects as a result and reference this ticket.
The text was updated successfully, but these errors were encountered: