RedisStore leaks Pub/Sub channels (with test case)

[shapeshed]

I have created a simple test case to demonstrate that RedisStore is leaking pubsub channels when using xhr-polling on both a single and clustered processes. This uses the following versions.

• Node 0.8.14
• Socket.IO 0.9.11

The test starts a stripped down Socket.IO server and then another process connects 100 xhr-polling clients at a rate of 1 per second. The server logs Redis Pub/Sub data and the number of connected sockets.

Single Process

The single process uses this server. On a single process here are the results of the test showing leaking Pub/Sub channels.

I have created a patch for this. Here are the results of the test using the patch

Clustered processes

The Clustered process test uses this server. Here is a graph of one of two processes showing leaking Pub/Sub channels and connections.

Results with the patch show connections are removed ok but Pub/Sub channels still leak.

[Cinamonas]

The patch did fix leaking pubsubs, thanks!