-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.3.0 broken #1505
Labels
bug
Something isn't working
Comments
Hi! The following should work: const { io } = require('socket.io-client')
const socket = io('http://localhost:7000', {}) That is a breaking change though, I'm digging into this 👀 |
Thank you! |
darrachequesne
added a commit
that referenced
this issue
Oct 15, 2021
The default export was accidentally removed in [1]. Note: that being said, users are encouraged to use the named exports, because the default export has a different meaning for CommonJS and ES modules users. ```js // BAD import io from "socket.io-client"; // GOOD import { io } from "socket.io-client"; ``` Related: - #1505 - #1507 - #1508 [1]: 16b6569
This should be fixed in version 4.3.1, sorry for this. |
sunrise30
added a commit
to sunrise30/socket.io-client
that referenced
this issue
Jan 8, 2022
The default export was accidentally removed in [1]. Note: that being said, users are encouraged to use the named exports, because the default export has a different meaning for CommonJS and ES modules users. ```js // BAD import io from "socket.io-client"; // GOOD import { io } from "socket.io-client"; ``` Related: - socketio/socket.io-client#1505 - socketio/socket.io-client#1507 - socketio/socket.io-client#1508 [1]: socketio/socket.io-client@16b6569
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4.3.0 is broken
io
is not a functionTo Reproduce
error output
Package version
Expected behavior
io
should be a functionThe text was updated successfully, but these errors were encountered: