Websocket compression [DONT MERGE] #343
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request adds support for websocket compression, which was added to Socket.io in version 1.4. This is a basic implementation which still has some outstanding issues, therefore
[DONT MERGE]
was added to the title of the issue.Sec-WebSocket-Extensions
header and the negotiation of thepermessage-deflate
extension.zlib
library. Required using an Objective-C helper class to interface withzlib
as it wasn't possible or easy to use that library's C API from within Swift.Remaining issues:
response.bytesLeft -= Int(dataLength)
is correct for handling partial frames. Test when extra data is present (ie. next frame)Because the client and server may reuse their DEFLATE context between messages...
)