Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix never running timingOut due to weak self capture #1463

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

davidkessler-ch
Copy link
Contributor

@davidkessler-ch davidkessler-ch commented Nov 10, 2023

Refer to: this issue

Fixed [the timeOut callback function never running] by removing the weak self capture in the timingOut function. Not sure why self is lost in the first place, but retain cycles are not a problem since they are only temporary anyways with asyncAfter(...) { }

@nuclearace nuclearace changed the base branch from master to development November 13, 2023 20:34
@nuclearace nuclearace merged commit 76b9419 into socketio:development Nov 13, 2023
1 check passed
@mendimr
Copy link

mendimr commented Jul 12, 2024

@nuclearace Any news when this PR will be merged with main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants