Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix test command in readme #547

Merged
merged 1 commit into from
Dec 27, 2017
Merged

[docs] Fix test command in readme #547

merged 1 commit into from
Dec 27, 2017

Conversation

andrew
Copy link
Contributor

@andrew andrew commented Dec 21, 2017 •
edited
Loading

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

Was make test but no makefile in repo

New behaviour

Update readme to npm test instead

@andrew
[docs] Fix test command in readme
be6e3cf 
Was `make test` but appears to be `npm test` now
@darrachequesne darrachequesne merged commit 7a3c267 into socketio:master Dec 27, 2017
@darrachequesne
Copy link
Member

Good catch, thanks!

@andrew andrew deleted the fix-test-command-in-readme branch December 28, 2017 20:45
darrachequesne pushed a commit that referenced this pull request Feb 18, 2018
@andrew @darrachequesne
[docs] Update test command in README (#547)
d7aaf2b
@darrachequesne darrachequesne added this to the 3.1.5 milestone Feb 25, 2018
@ajesse11x ajesse11x mentioned this pull request Jan 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@andrew @darrachequesne