Fix sockets can stay open when upgrade failed #344
Merged
+47
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauchg
added a commit
that referenced
this pull request
Aug 29, 2015
Fix sockets can stay open when upgrade failed
|
The lack of these for such critical bugs is disturbing. |
|
"of tests" you mean? We have really solid coverage for the behaviors changed here. |
|
Yes, "tests". Well this fixes a critical bug, yet there are no tests added to ensure that this never happens before. While the coverage for behaviors might be great, coverage for these kind of bugs is not |
|
I will see If I can add tests. |
darrachequesne
pushed a commit
that referenced
this pull request
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading transports will never be closed if
Socket#onClosewas called and thenupgradeTimeoutTimerwas cleared.This PR ensures
checkIntervalTimerto be cleared and prevents possible upgrade request overlap too.