Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependency ws to version 1.1.2 #540

Closed
wants to merge 1 commit into from

Conversation

pmuellr
Copy link

@pmuellr pmuellr commented Feb 16, 2017

fixes: #538
'dependency on "ws" version < 2.00 has security flaw in random
number generator'

Note: the engine.io.js file is the generated output of make engine.io.js, and should not be manually modified.

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

New behaviour

Other information (e.g. related issues)

From the doc, I ran the following tests, with the resultant output. I don't have a saucelabs account, so it sounds like not all the tests could have been run.

$ npm test

> [email protected] test /Users/pmuellr/Projects/forks/engine.io-client
> gulp test

[20:42:31] Using gulpfile ~/Projects/forks/engine.io-client/gulpfile.js
[20:42:31] Starting 'lint'...
[20:42:33] Finished 'lint' after 1.69 s
[20:42:33] Starting 'test'...


  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․

  53 passing (4s)

$ ./node_modules/.bin/zuul --local 8080 -- test/index.js

$ make test
[20:47:22] Using gulpfile ~/Projects/forks/engine.io-client/gulpfile.js
[20:47:22] Starting 'lint'...
[20:47:23] Finished 'lint' after 1.49 s
[20:47:23] Starting 'test'...


  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․

  53 passing (4s)

fixes: socketio#538
'dependency on "ws" version < 2.00 has security flaw in random
number generator'
@pmuellr
Copy link
Author

pmuellr commented Feb 16, 2017

Welp, that'll teach me for not looking at the existing PRs first.

DUP of PR #539 , so closing ...

@pmuellr pmuellr closed this Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dependency on "ws" version < 2.00 has security flaw in random number generator
1 participant