Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox + Web Worker, mangles utf-8 #595

Closed
1 of 2 tasks
devoidfury opened this issue Mar 6, 2018 · 1 comment
Closed
1 of 2 tasks

Firefox + Web Worker, mangles utf-8 #595

devoidfury opened this issue Mar 6, 2018 · 1 comment
Milestone

Comments

@devoidfury
Copy link
Contributor

devoidfury commented Mar 6, 2018

Note: for support questions, please use one of these channels: stackoverflow or slack

You want to:

  • report a bug
  • request a feature

Current behaviour

Using the client in a Worker on firefox, it does not handle utf-8 correctly.

Steps to reproduce (if the current behaviour is a bug)

Send a higher-ranged utf-8 character as json-encoded plaintext message to a client running firefox browser, with the engine.io-client running inside a Worker.

It works fine in Chrome with or without the web worker, and it also works fine in firefox outside a web worker.

For reference, this is the string that caused it to break for me: "пойду сать всем мпокойной ночи"

Setup

  • OS: Linux inferno 4.15.6-1-ARCH SMP PREEMPT Sun Feb 25 12:53:23 UTC 2018 x86_64 GNU/Linux
  • browser: Firefox 58.0.2 (64-bit)
  • engine.io version: 3.1.5 and 3.2.0

Other information (e.g. stacktraces, related issues, suggestions how to fix)

I don't have a test case atm, but I'll try to make you one this week when things calm down a bit over here.

devoidfury added a commit to devoidfury/engine.io-client that referenced this issue Mar 7, 2018
@darrachequesne darrachequesne added this to the 3.2.1 milestone Mar 9, 2018
@darrachequesne
Copy link
Member

Fixed by #596.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants