-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please upgrade ws to 0.8 and bump engine.io-client version #412
Comments
+1 |
update landed in 1.5.4 |
@CxRes no, I believe it did not. The socket.io-client dependency needs to be updated to socketio/socket.io-client@4c22f33 |
@aaronjensen this is closed because engine.io-client has landed the change. socket.io-client is an upstream with dependency on engine.io-client. I can see you have an upstream ticket. I have also made a comment to @rauchg and @nkzawa in ticket socketio/socket.io#2213 pointing to the commits that they need to update in package.json in socket.io and socket.io-client. I hope you find this ok! |
My mistake, I forgot to check which repo I was commenting on. Thank you! Aaron On Fri, Sep 11, 2015 at 12:23 PM, CxRes [email protected] wrote:
|
ws 0.8 fixes issues with iojs 3.0.0 (see websockets/ws#555). Please upgrade engine.io-client to reflect this!
The text was updated successfully, but these errors were encountered: