Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please upgrade ws to 0.8 and bump engine.io-client version #412

Closed
CxRes opened this issue Aug 21, 2015 · 8 comments
Closed

Please upgrade ws to 0.8 and bump engine.io-client version #412

CxRes opened this issue Aug 21, 2015 · 8 comments

Comments

@CxRes
Copy link

CxRes commented Aug 21, 2015

ws 0.8 fixes issues with iojs 3.0.0 (see websockets/ws#555). Please upgrade engine.io-client to reflect this!

@gsklee
Copy link

gsklee commented Sep 4, 2015

gsklee pushed a commit to gsklee/engine.io-client that referenced this issue Sep 4, 2015
@masakij
Copy link

masakij commented Sep 9, 2015

+1

@marcelaraujo
Copy link

owwww

image

@CxRes
Copy link
Author

CxRes commented Sep 11, 2015

update landed in 1.5.4

@CxRes CxRes closed this as completed Sep 11, 2015
@aaronjensen
Copy link

@CxRes no, I believe it did not. The socket.io-client dependency needs to be updated to socketio/socket.io-client@4c22f33

@aaronjensen
Copy link

@CxRes see socketio/socket.io#2235

@CxRes
Copy link
Author

CxRes commented Sep 11, 2015

@aaronjensen this is closed because engine.io-client has landed the change. socket.io-client is an upstream with dependency on engine.io-client. I can see you have an upstream ticket. I have also made a comment to @rauchg and @nkzawa in ticket socketio/socket.io#2213 pointing to the commits that they need to update in package.json in socket.io and socket.io-client.

I hope you find this ok!

@aaronjensen
Copy link

My mistake, I forgot to check which repo I was commenting on. Thank you!

Aaron

On Fri, Sep 11, 2015 at 12:23 PM, CxRes [email protected] wrote:

@aaronjensen this is closed because engine.io-client has landed the change. socket.io-client is an upstream with dependency on engine.io-client. I can see you have an upstream ticket. I have also made a comment to @rauchg and @nkzawa in ticket socketio/socket.io#2213 pointing to the commits that they need to update in package.json in socket.io and socket.io-client.

I hope you find this ok!

Reply to this email directly or view it on GitHub:
#412 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants