fix(typings): do not expose browser-specific types

Related: - socketio/socket.io-client#1561 - b9252e2
socketio · Feb 4, 2023 · 37d7a0a · 37d7a0a
1 parent c36883d
commit 37d7a0a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/transport.ts b/lib/transport.ts
@@ -21,7 +21,7 @@ class TransportError extends Error {
 
 export interface CloseDetails {
   description: string;
-  context?: CloseEvent | XMLHttpRequest;
+  context?: unknown; // context should be typed as CloseEvent | XMLHttpRequest, but these types are not available on non-browser platforms
 }
 
 interface TransportReservedEvents {

diff --git a/lib/transports/polling.ts b/lib/transports/polling.ts
@@ -292,7 +292,7 @@ export class Polling extends Transport {
 interface RequestReservedEvents {
   success: () => void;
   data: (data: RawData) => void;
-  error: (err: number | Error, context: XMLHttpRequest) => void;
+  error: (err: number | Error, context: unknown) => void; // context should be typed as XMLHttpRequest, but this type is not available on non-browser platforms
 }
 
 export class Request extends Emitter<{}, {}, RequestReservedEvents> {