Website: Rounded flags #982
Conversation
dnhn
requested review from
andrashee,
mkue,
ssandino and
socialincome-dev
as code owners
|
@dnhn is attempting to deploy a commit to the Social Income Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThe changes in this pull request involve modifications to the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
website/src/app/[lang]/[region]/(website)/transparency/finances/[currency]/section-3-cards.tsx(2 hunks)
🔇 Additional comments (1)
website/src/app/[lang]/[region]/(website)/transparency/finances/[currency]/section-3-cards.tsx (1)
27-27: LGTM: Clean implementation of rounded flags
The styling changes effectively implement the rounded flags requirement using Tailwind's utility classes:
size-12(equivalent to h-12 w-12) maintains dimensionsrounded-fullcreates perfect circlesflex-noneprevents unwanted flexing
| @@ -7,7 +7,7 @@ import { Children, PropsWithChildren, useState } from 'react'; | |||
| * We use the files from GitHub instead of the package so that donations from new countries are automatically supported. | |||
| */ | |||
| const getFlagImageURL = (country: string) => { | |||
| return `https://raw.githubusercontent.com/lipis/flag-icons/a87d8b256743c9b0df05f20de2c76a7975119045/flags/4x3/${country.toLowerCase()}.svg`; | |||
| return `https://raw.githubusercontent.com/lipis/flag-icons/a87d8b256743c9b0df05f20de2c76a7975119045/flags/1x1/${country.toLowerCase()}.svg`; | |||
There was a problem hiding this comment.
💡 Codebase verification
Update flag-icons commit hash to latest version e119b66129af
The current commit hash (a87d8b2) is outdated. The latest commit hash (e119b66) includes potential improvements and fixes to the flag icons.
- Update line 10 to use the latest commit:
return `https://raw.githubusercontent.com/lipis/flag-icons/e119b66129af/flags/1x1/${country.toLowerCase()}.svg`;🔗 Analysis chain
Consider implications of pinned commit hash
While using a specific commit hash (a87d8b256743) ensures stability, it prevents automatic updates for flag improvements or fixes.
Let's check if this is the latest commit:
Consider implementing a version update strategy or documenting when/how to update this hash.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check latest commit of flag-icons repository
gh api repos/lipis/flag-icons/commits/main --jq '.sha[0:12]'
Length of output: 75
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
The build is failed, am I missing something? |
|
I think this is because you’re (now as part of the team) merging from your own codebase directly into our main branch (which has some branch protection rules). Normally, we create the PR branch directly within our codebase (which you should have access to). If you create a new branch and save it directly in our codebase, it should work as expected. |
Resolve #977
Summary by CodeRabbit
New Features
Bug Fixes