Website: Extract translations for campaign and add Italian translation #954
Conversation
andrashee
requested review from
mkue,
ssandino and
socialincome-dev
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 WalkthroughWalkthroughThis pull request introduces new localization files for campaign-related messages in German, English, French, and Italian, while removing the campaign section from existing donation localization files in the same languages. Additionally, changes are made to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (8)
shared/locales/de/website-campaign.json(1 hunks)shared/locales/de/website-donate.json(0 hunks)shared/locales/en/website-campaign.json(1 hunks)shared/locales/en/website-donate.json(0 hunks)shared/locales/fr/website-campaign.json(1 hunks)shared/locales/fr/website-donate.json(0 hunks)shared/locales/it/website-campaign.json(1 hunks)website/src/app/[lang]/[region]/(website)/campaign/[campaign]/page.tsx(1 hunks)
💤 Files with no reviewable changes (3)
- shared/locales/en/website-donate.json
- shared/locales/de/website-donate.json
- shared/locales/fr/website-donate.json
✅ Files skipped from review due to trivial changes (4)
- shared/locales/de/website-campaign.json
- shared/locales/it/website-campaign.json
- shared/locales/fr/website-campaign.json
- shared/locales/en/website-campaign.json
🔇 Additional comments (1)
website/src/app/[lang]/[region]/(website)/campaign/[campaign]/page.tsx (1)
59-59: LGTM: Context change aligns with translation separation
The metadata context change from 'website-donate' to 'website-campaign' correctly reflects the separation of campaign translations.
|
Visit the preview URL for this PR (updated for commit 0987cdd): https://si-admin-staging--pr954-ahee-campaign-extrac-bizfk251.web.app (expires Tue, 10 Dec 2024 19:55:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b7b0969384059dce6ea8fad1ee1d1737e54e6676 |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
shared/locales/it/website-donate.json (1)
26-28: Consider adding the "text" field for consistencyOther interval options include both "title" and "text" fields. Consider adding the "text" field to maintain consistency.
"0": { - "title": "Donazione una tantum" + "title": "Donazione una tantum", + "text": "Fai una donazione una tantum" },shared/locales/it/website-videos.json (1)
42-45: Consider splitting translator creditsThe translator entry combines multiple languages and names. Consider splitting this into separate entries for better maintainability:
- { - "role": "Traduttore (Sottotitoli)", - "name": "Françoise Légeret (FR), Riccardo Tamburini (ES, IT)" - } + { + "role": "Traduttore Francese (Sottotitoli)", + "name": "Françoise Légeret" + }, + { + "role": "Traduttore Spagnolo e Italiano (Sottotitoli)", + "name": "Riccardo Tamburini" + }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
shared/locales/it/website-donate.json(1 hunks)shared/locales/it/website-videos.json(1 hunks)
🔇 Additional comments (2)
shared/locales/it/website-donate.json (1)
26-28: LGTM! Translation is consistent
The translation "Donazione una tantum" is consistent with other occurrences in the file.
shared/locales/it/website-videos.json (1)
48-79: LGTM!
The credits for both videos are well-structured and consistent.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation