Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(general): mailchimp api integration #747

Merged
merged 12 commits into from
Mar 12, 2024
Merged

feature(general): mailchimp api integration #747

merged 12 commits into from
Mar 12, 2024

Conversation

brennerthomas
Copy link
Contributor

  • Adding in shared the Event Handler --> can be used by all apps
  • Adding a specific next.js api for Mailchimp inside the Website

- Adding in shared the Event Handler --> can be used by all apps
- Adding a specific next.js api for Mailchimp inside the Website
Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
public ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 10:50pm

Copy link

github-actions bot commented Feb 12, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://socialincome-san.github.io/public/pr-preview/pr-747/
on branch gh-pages at 2024-03-12 22:41 UTC

Copy link

github-actions bot commented Feb 12, 2024

Visit the preview URL for this PR (updated for commit 725e173):

https://si-admin-staging--pr747-mailchimp-api-m1xsuyjd.web.app

(expires Tue, 19 Mar 2024 22:46:36 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b7b0969384059dce6ea8fad1ee1d1737e54e6676

@mkue mkue changed the title Initial Commit for Mailchimp API feature(general): mailchimp api integration Mar 2, 2024
@mkue
Copy link
Contributor

mkue commented Mar 2, 2024

looks very good @brennerthomas!

i changed the api endpoints a bit to prevent a security issue so that users can only change their own mailchimp subscription.

also, i started with the integration in the frontend, but it's just dummy code yet. feel free to polish it if you want :)

the useUpdateMailchimpSubscription(), useCreateMailchimpSubscription() hooks take use of react-query, which is very handy if you want to refetch some data after an update has been made. if you have trouble understanding that code, i can explain it to you in person at some point :)

Copy link
Contributor

@mkue mkue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff @brennerthomas 🙌🏼🙌🏼

@mkue mkue merged commit c7335f9 into main Mar 12, 2024
19 checks passed
@mkue mkue deleted the Mailchimp-api branch March 12, 2024 22:51
@ssandino
Copy link
Member

very nice @brennerthomas 🙌🏼🙌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants