feature(website): campaign page #725
Conversation
andrashee
requested review from
mkue,
ssandino and
renestalder
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
Visit the preview URL for this PR (updated for commit 81a9486): https://si-admin-staging--pr725-ahee-camaign-page-b2z49cjj.web.app (expires Sun, 17 Mar 2024 14:57:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b7b0969384059dce6ea8fad1ee1d1737e54e6676 |
|
Fabulous! Happy to help with text and styling inputs! |
There was a problem hiding this comment.
Very cool stuff @andrashee!
If we want to have this look nicer, I think we should first draw some mockups. For the moment, it looks good to me🙌🏼
| </div> | ||
| {daysLeft >= 0 && ( | ||
| <Fragment> |
There was a problem hiding this comment.
nit: I always use <></>. But it's exactly the same...
| </BaseContainer> | ||
| ); | ||
| } | ||
|
|
||
| const daysUntilTs = (ts: Date): number => { |
There was a problem hiding this comment.
I would move this to /shared/src/utils/date.ts. That's where other date utility functions are located.
Agree! Very cool. @mkue @andrashee I made some mockups in our Figma file (see page Campaign Page wip). For the moment just ideas about how to place things and what to include (and only for the case, where person chooses a goal) – so it's more starter to discuss, feel free to comment here or directly in the Figma file if easier. I took two elements from the newly proposed design: background color and FAQ. (new designs from Milk you also find in the Figma) Here my favourite so far: |
|
@mkue @andrashee I asked @johanneswicki for input on the mockup. He has come up with another version ("ich habe hier versucht, das ganze etwas grosszügiger zu machen und damit mehr die künftige landing page zu matchen")
Any inputs for a next version? 
|
|
Thanks a lot @ssandino, the mock-up look great! If you have time tomorrow, we could discuss some details. Would be free in the afternoon. |
Towards a campaign page. Still needs fine-tuning, but the payment association already works.
No contributions yet:
Some contributions:
No goals:
Last day to contribute:
1 day to contribute
Todos