Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(website): refined navbar #636

Merged
merged 8 commits into from
Nov 20, 2023
Merged

feature(website): refined navbar #636

merged 8 commits into from
Nov 20, 2023

Conversation

ssandino
Copy link
Member

Refined NavBar: Adjusted Logo Sizes and Optimized Whitespace & Text for Mobile/Web Views

Out of scope was the CTA button "Take Action".

Comparison
Left: old / Right: new

Screenshot 2023-11-16 at 19 27 19 Screenshot 2023-11-16 at 19 28 21 Screenshot 2023-11-16 at 19 29 00 Screenshot 2023-11-16 at 19 30 06

Copy link

vercel bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
public ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2023 8:53pm

@ssandino ssandino changed the title Refined NavBar feature(website): refined navbar Nov 16, 2023
Copy link

github-actions bot commented Nov 16, 2023

Visit the preview URL for this PR (updated for commit a5955ee):

https://si-admin-staging--pr636-sandino-navbar-styli-00tg0dce.web.app

(expires Sun, 26 Nov 2023 20:52:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b7b0969384059dce6ea8fad1ee1d1737e54e6676

Copy link

PR Preview Action v1.4.4
🚀 Deployed preview to https://socialincome-san.github.io/public/pr-preview/pr-636/
on branch gh-pages at 2023-11-19 18:36 UTC

shared/locales/en/website-common.json Outdated Show resolved Hide resolved
website/src/components/navbar/navbar-client.tsx Outdated Show resolved Hide resolved
@ssandino
Copy link
Member Author

@mkue addressed pending issues

@ssandino ssandino requested a review from mkue November 19, 2023 20:57
Copy link
Contributor

@mkue mkue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good🙌🏼

@mkue mkue merged commit dad1e75 into main Nov 20, 2023
21 checks passed
@mkue mkue deleted the sandino/navbar-styling branch November 20, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants