Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy - paste almost works perfectly #2

Closed
olliraa opened this issue Apr 26, 2019 · 8 comments
Closed

Copy - paste almost works perfectly #2

olliraa opened this issue Apr 26, 2019 · 8 comments

Comments

@olliraa
Copy link

olliraa commented Apr 26, 2019

Hi.

This plugin is just awesome, the missing support for tables has been a real problem, because people (especially engineers ;) take copy - paste from Excel as granted feature.

I found a bug/problem with the copy - paste feature. If I try to copy a table, the pasted table looks kinda odd -> the borders for the second column are missing? Here's an example:

https://drive.google.com/file/d/1rfpHVa4Y5DbI_vn4Inc5Y7Dj_N4TAWmS/view?usp=sharing

@soccerloway
Copy link
Owner

@olliraa Thank you for encouraging.
I tried copying a table from Mac Numbers, then pasted in the demo. It worked well.
Would you please tell me more details? I must be glad to fix it.
Is there any lists in the copied table cell ? List in table cell is not currently supported.

@olliraa
Copy link
Author

olliraa commented Apr 29, 2019

Hi, thanks for the reply :) The problem is that if I copy paste a 2x2 table from Excel (Windows) from cells (A1, B1, A2, B2) only the A1 and A2 have borders. If I copy the same content from anywhere else in the same Excel sheet, I get borders for all the 4 cells. Weird :) See here:
[https://drive.google.com/file/d/1UC-dJIQvBU2fqFDNPtvdvmMP7XUPuyg0/view?usp=sharing]

@soccerloway
Copy link
Owner

@olliraa Thanks a lot. I reproduced this bug just now.
I found that the HTML structure of a table copied from Excel has some col tags missing.
col tags are important for the width of table cell. The column will be 0 width if the corresponding col tag missing, and it looks like the borders for the column are missing. I will fix it in next few days.

By the way, I found another bug that empty table cells are missing durring pasting.
Thank you :)

@olliraa
Copy link
Author

olliraa commented May 2, 2019

Great, thank you soo much :)

@soccerloway
Copy link
Owner

@olliraa This problem has been fixed in v1.1.2, update the package, you will have a better table:).
Star me and give me more suggestions. lol~

@olliraa
Copy link
Author

olliraa commented May 6, 2019 via email

@soccerloway
Copy link
Owner

@olliraa Thanks a lot.
About alignment for table
First, I wrapped table with a scrollable div to show intact table, and the width of scrollable div was 100 percent.
Second, to achieve that, it must change the layout styles and change the algorithm for table operations. The complexity will increase.
Unfortunately, I think that alignment for table is hard to achieve in this repo.
But it is easy to center the table by margin: 0 auto in rendering.
I will open a new issue for your requirement to discuss.

@olliraa
Copy link
Author

olliraa commented May 7, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants