Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconsider directions about adding other users to git-secret repo #813

Closed
joshrabinowitz opened this issue Apr 1, 2022 · 1 comment · Fixed by #814
Closed

reconsider directions about adding other users to git-secret repo #813

joshrabinowitz opened this issue Apr 1, 2022 · 1 comment · Fixed by #814

Comments

@joshrabinowitz
Copy link
Collaborator

In
https://github.com/sobolevn/git-secret/blob/master/man/man7/git-secret.7.md#usage-adding-someone-to-a-repository-using-git-secret
we say:

Usage: Adding someone to a repository using git-secret

  • Get their gpg public-key
  • Import this key into your gpg keyring (in ~/.gnupg or similar) by running gpg --import KEY_NAME.txt
  • (more steps follow)

Is this good advice? Should we also be telling them to remove that user's public key from their keyring as the final step?

This issue relates to #699

@sobolevn
Copy link
Owner

sobolevn commented Apr 1, 2022

I think importing public keys is fine if you remove it afterwards!
Very good catch! 👍

joshrabinowitz pushed a commit to joshrabinowitz/git-secret that referenced this issue Apr 1, 2022
sobolevn added a commit that referenced this issue Apr 2, 2022
* updates for #813

* update man pages

* Update utils/tests.sh

Co-authored-by: joshr <joshr>
Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants