Skip to content

Commit

Permalink
Try to repair oddball test bots timing out in test_int (python#119166)
Browse files Browse the repository at this point in the history
Various test bots (outside the ones GH normally runs) are timing out during test_int after ecd8664 (asymptotically faster str->int). Best guess is that they don't build the C _decimal module. So require that module in the most likely tests to time out then. Flying mostly blind, though!
  • Loading branch information
tim-one authored May 19, 2024
1 parent ecd8664 commit ba8af84
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions Lib/test/test_int.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@
except ImportError:
_pylong = None

try:
import _decimal
except ImportError:
_decimal = None

L = [
('0', 0),
('1', 1),
Expand Down Expand Up @@ -920,6 +925,7 @@ def test_pylong_roundtrip(self):
bits <<= 1

@support.requires_resource('cpu')
@unittest.skipUnless(_decimal, "C _decimal module required")
def test_pylong_roundtrip_huge(self):
# k blocks of 1234567890
k = 1_000_000 # so 10 million digits in all
Expand All @@ -931,6 +937,7 @@ def test_pylong_roundtrip_huge(self):

@support.requires_resource('cpu')
@unittest.skipUnless(_pylong, "_pylong module required")
@unittest.skipUnless(_decimal, "C _decimal module required")
def test_whitebox_dec_str_to_int_inner_failsafe(self):
# While I believe the number of GUARD digits in this function is
# always enough so that no more than one correction step is ever
Expand All @@ -950,6 +957,7 @@ def test_whitebox_dec_str_to_int_inner_failsafe(self):
_pylong._spread.update(orig_spread)

@unittest.skipUnless(_pylong, "pylong module required")
@unittest.skipUnless(_decimal, "C _decimal module required")
def test_whitebox_dec_str_to_int_inner_monster(self):
# I don't think anyone has enough RAM to build a string long enough
# for this function to complain. So lie about the string length.
Expand Down

0 comments on commit ba8af84

Please sign in to comment.