Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle nonexisting LS version #557

Merged
merged 21 commits into from
Nov 13, 2024
Merged

fix: handle nonexisting LS version #557

merged 21 commits into from
Nov 13, 2024

Conversation

ShawkyZ
Copy link
Contributor

@ShawkyZ ShawkyZ commented Nov 11, 2024 •
edited by bastiandoetsch
Loading

Description

  • Fix openSettings command
  • Set CLI Release channel to preview if extension is preview.
  • Custom error when download fails

image

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@ShawkyZ ShawkyZ changed the title fix: wip set cli channel preview fix: handle nonexisting LS version Nov 12, 2024
@ShawkyZ ShawkyZ marked this pull request as ready for review November 12, 2024 18:03
@ShawkyZ ShawkyZ requested a review from a team as a code owner November 12, 2024 18:03
bastiandoetsch
bastiandoetsch approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@bastiandoetsch bastiandoetsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeeehaa 🎉

@ShawkyZ ShawkyZ merged commit b1218bd into main Nov 13, 2024
10 checks passed
@ShawkyZ ShawkyZ deleted the fix/set-cli-channel-preview branch November 13, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastiandoetsch bastiandoetsch bastiandoetsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShawkyZ @bastiandoetsch