Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve readability of code elements in high-contrast themes #508

Merged
merged 1 commit into from
Aug 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Snyk Security Changelog

## [2.16.3]
- fix readability of `code` elements within the **overview** section when using high-contrast themes (both dark and light). Text color now matches the background.

## [2.16.2]
- updated the language server protocol version to 14 to support new communication model.

Expand Down
12 changes: 11 additions & 1 deletion media/views/oss/suggestion/suggestion.scss
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
}

.delimiter {
border-right:1px solid var(--vscode-input-border);
border-right: 1px solid var(--vscode-input-border);
}

.vulnerability-overview pre {
Expand All @@ -37,3 +37,13 @@
font-size: var(--vscode-editor-font-size);
font-family: var(--vscode-editor-font-family);
}

/* High-contrast dark mode */
.vscode-high-contrast:not(.vscode-high-contrast-light) .vulnerability-overview code {
color: var(--vscode-editor-background);
}

/* High-contrast light mode */
.vscode-high-contrast.vscode-high-contrast-light .vulnerability-overview code {
color: var(--vscode-editor-background);
}
Loading