Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add configuration setting for authentication method, default to token [IDE-459] #500

Merged
merged 10 commits into from
Jul 26, 2024
Merged

feat: add configuration setting for authentication method, default to token [IDE-459] #500

merged 10 commits into from
Jul 26, 2024

Conversation

bastiandoetsch
Copy link
Contributor

@bastiandoetsch bastiandoetsch commented Jul 24, 2024 •
edited
Loading

Description

  • Changes text copy of welcome view
  • Add setting combo for Authentication Method
  • Default to Token until we officially move to OAuth2 as a default.

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

image
image
image
image

@bastiandoetsch bastiandoetsch added the ⚠️ DON'T MERGE Shouldn't be merged yet. label Jul 24, 2024
@bastiandoetsch bastiandoetsch marked this pull request as ready for review July 25, 2024 06:59
@bastiandoetsch bastiandoetsch requested a review from a team as a code owner July 25, 2024 06:59
@bastiandoetsch bastiandoetsch removed the ⚠️ DON'T MERGE Shouldn't be merged yet. label Jul 25, 2024
@bastiandoetsch bastiandoetsch changed the title feat: add configuration setting for authentication method, default to OAuth2 [IDE-459] feat: add configuration setting for authentication method, default to token [IDE-459] Jul 25, 2024
@Arvi3d
Copy link
Contributor

Arvi3d commented Jul 25, 2024

LOVING IT

@bastiandoetsch bastiandoetsch force-pushed the feat/IDE-459_authentication-flow branch from 39b7028 to ba57e09 Compare July 26, 2024 06:20
@bastiandoetsch bastiandoetsch force-pushed the feat/IDE-459_authentication-flow branch from ba57e09 to 4b5f0c3 Compare July 26, 2024 06:25
@bastiandoetsch bastiandoetsch merged commit 56f6d4a into main Jul 26, 2024
10 checks passed
@bastiandoetsch bastiandoetsch deleted the feat/IDE-459_authentication-flow branch July 26, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShawkyZ ShawkyZ ShawkyZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastiandoetsch @Arvi3d @ShawkyZ