Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: settings categories regrouped #499

Merged
merged 1 commit into from
Jul 25, 2024
Merged

chore: settings categories regrouped #499

merged 1 commit into from
Jul 25, 2024

Conversation

Arvi3d
Copy link
Contributor

@Arvi3d Arvi3d commented Jul 24, 2024

Description

This is a continuation of a work done in this PR earlier: #496

The aim is to make an order of categories more logical according to usage pattern.
This is just an iteration. we will continue improving it.

There are few duplicating and possible unneeded settings left

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@Arvi3d Arvi3d requested a review from a team as a code owner July 24, 2024 14:03
cat2608
cat2608 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@cat2608 cat2608 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense! Thank you !! 🚀

image

bastiandoetsch
bastiandoetsch reviewed Jul 25, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
bastiandoetsch
bastiandoetsch reviewed Jul 25, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
bastiandoetsch
bastiandoetsch requested changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@bastiandoetsch bastiandoetsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss this before merging it - this is the first time I see this iteration on the configuration and I think we should discuss it :)

@Arvi3d Arvi3d force-pushed the chore/settings-categories branch 2 times, most recently from 8a8ab0b to 6ca85fb Compare July 25, 2024 08:15
@Arvi3d
Copy link
Contributor Author

Arvi3d commented Jul 25, 2024

Hi folks, I've made adjustments to this based on the conversation with @bastiandoetsch

  1. renamed "filters" -> "Scan configuration"
  2. moved additional parameters to "scan configration"
  3. renamed "Onboarding" -> "Initialization"
  4. renamed "Snyk CLI" -> "CLI & Language server"

let me know what you think.

@Arvi3d Arvi3d requested review from bastiandoetsch and cat2608 July 25, 2024 08:19
bastiandoetsch
bastiandoetsch approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@bastiandoetsch bastiandoetsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me :)

@Arvi3d Arvi3d force-pushed the chore/settings-categories branch from 6ca85fb to 948ba7c Compare July 25, 2024 10:57
@Arvi3d Arvi3d merged commit e862dee into main Jul 25, 2024
10 checks passed
@Arvi3d Arvi3d deleted the chore/settings-categories branch July 25, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastiandoetsch bastiandoetsch bastiandoetsch approved these changes

@cat2608 cat2608 cat2608 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arvi3d @cat2608 @bastiandoetsch