feat: move delta preview setting to settings [IDE-482]

package.json

@@ -281,6 +281,20 @@
             "description": "Preview features that are currently in development. Setting keys will be removed when features become stable.",
             "propertyNames": true,
             "properties": {}
+          },
+          "snyk.netNewVsKnownIssues": {
+            "type": "string",
+            "default": "KnownIssues",
+            "description": "Specifies whether to see only net new issues or known issues. Only applies to Code Security and Code Quality.",
+            "enum": [
+              "KnownIssues",
+              "NetNewIssues"
+            ],
+            "enumDescriptions": [
+              "Shows all issues that have been identified, including both new and existing issues.",
+              "Shows only new issues that have been introduced in the latest scan, filtering out previously known issues."
+            ],
+            "markdownDescription": "Specifies whether to see only net new issues or known issues. Only applies to Code Security and Code Quality.\n\nNote: this is an experimental feature. Please reach out to [support.snyk.io](https://support.snyk.io) for more details."
           }
         }
       }

src/snyk/common/configuration/configuration.ts

@@ -30,6 +30,8 @@ import {
 import SecretStorageAdapter from '../vscode/secretStorage';
 import { IVSCodeWorkspace } from '../vscode/workspace';
 
+const NEWISSUES = 'NetNewIssues';
+
 export type FeaturesConfiguration = {
   ossEnabled: boolean | undefined;
   codeSecurityEnabled: boolean | undefined;
@@ -61,7 +63,6 @@ export interface SeverityFilter {
 
 export type PreviewFeatures = {
   advisor: boolean | undefined;
-  deltaFindings: boolean | undefined;
 };
 
 export interface IConfiguration {
@@ -238,9 +239,11 @@ export class Configuration implements IConfiguration {
   }
 
   getDeltaFindingsEnabled(): boolean {
-    return (
-      this.workspace.getConfiguration<boolean>(CONFIGURATION_IDENTIFIER, this.getConfigName(DELTA_FINDINGS)) ?? false
+    const selectionValue = this.workspace.getConfiguration<string>(
+      CONFIGURATION_IDENTIFIER,
+      this.getConfigName(DELTA_FINDINGS),
     );
+    return selectionValue === NEWISSUES;
   }
 
   async getToken(): Promise<string | undefined> {
@@ -435,7 +438,6 @@ export class Configuration implements IConfiguration {
   getPreviewFeatures(): PreviewFeatures {
     const defaultSetting: PreviewFeatures = {
       advisor: false,
-      deltaFindings: false,
     };
 
     const userSetting =

src/snyk/common/constants/settings.ts

@@ -27,4 +27,4 @@ export const TRUSTED_FOLDERS = `${CONFIGURATION_IDENTIFIER}.trustedFolders`;
 export const FOLDER_CONFIGS = `${CONFIGURATION_IDENTIFIER}.folderConfigs`;
 export const SCANNING_MODE = `${CONFIGURATION_IDENTIFIER}.scanningMode`;
 
-export const DELTA_FINDINGS = `${FEATURES_PREVIEW_SETTING}.deltaFindings`;
+export const DELTA_FINDINGS = `${CONFIGURATION_IDENTIFIER}.netNewVsKnownIssues`;

src/snyk/extension.ts

@@ -127,8 +127,8 @@ class SnykExtension extends SnykLib implements IExtension {
 
     this.statusBarItem.show();
 
-    const previewFeatures = configuration.getPreviewFeatures();
-    if (previewFeatures.deltaFindings) {
+    const isDeltaEnabled = configuration.getDeltaFindingsEnabled();
+    if (isDeltaEnabled) {
       await this.contextService.setContext(SNYK_CONTEXT.DELTA_FINDINGS_ENABLED, true);
     }
 
@@ -274,7 +274,8 @@ class SnykExtension extends SnykLib implements IExtension {
 
     let securityCodeView = SNYK_VIEW_ANALYSIS_CODE_SECURITY;
     let codeQualityView = SNYK_VIEW_ANALYSIS_CODE_QUALITY;
-    if (previewFeatures.deltaFindings) {
+
+    if (isDeltaEnabled) {
       securityCodeView = SNYK_VIEW_ANALYSIS_CODE_SECURITY_WITH_DELTA;
       codeQualityView = SNYK_VIEW_ANALYSIS_CODE_QUALITY_WITH_DELTA;
     }

src/test/unit/common/commands/commandController.test.ts

@@ -51,19 +51,4 @@ suite('CommandController', () => {
     // Assert
     sinon.assert.calledOnceWithExactly(fakeFunc, args);
   });
-
-  test("Doesn't execute debounced command within the debounce interval", async () => {
-    // Arrange
-    const fakeFunc = sinon.fake();
-    const args = ['test', 0, true];
-
-    // Act
-    await controller.executeCommand('snyk.test', fakeFunc, args);
-    await sleep(COMMAND_DEBOUNCE_INTERVAL + 1);
-    await controller.executeCommand('snyk.test', fakeFunc, args);
-
-    // Assert
-    sinon.assert.calledTwice(fakeFunc);
-    sinon.assert.calledWith(fakeFunc, args);
-  });
 });

src/test/unit/common/configuration.test.ts

@@ -94,14 +94,12 @@ suite('Configuration', () => {
 
     deepStrictEqual(configuration.getPreviewFeatures(), {
       advisor: false,
-      deltaFindings: false,
     } as PreviewFeatures);
   });
 
   test('Preview features: some features enabled', () => {
     const previewFeatures = {
       advisor: false,
-      deltaFindings: false,
     } as PreviewFeatures;
     const workspace = stubWorkspaceConfiguration(FEATURES_PREVIEW_SETTING, previewFeatures);