Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: toggle inline ignores button visibility based on feature flag [IDE-444] #493

Merged

Conversation

bastiandoetsch
Copy link
Contributor

@bastiandoetsch bastiandoetsch commented Jul 19, 2024

Description

This PR hides the footer with the ignore line and ignore file buttons when the feature flag exists in the settings of an organisation but is selected to false.

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

ORG with FF Enabled ORG with FF Disabled
ff-enabled ff-disabled

@bastiandoetsch bastiandoetsch changed the base branch from main to feat/IDE-440_retrieve-feature-flag-for-snykCodeInlineIgnore July 19, 2024 08:17
Base automatically changed from feat/IDE-440_retrieve-feature-flag-for-snykCodeInlineIgnore to main July 19, 2024 14:17
@cat2608 cat2608 force-pushed the feat/IDE-444_retrieve-feature-flag-for-snykCodeInlineIgnore branch from a49848c to dd1f969 Compare July 22, 2024 09:53
@cat2608 cat2608 force-pushed the feat/IDE-444_retrieve-feature-flag-for-snykCodeInlineIgnore branch from 7b86435 to e37bf24 Compare July 23, 2024 10:45
@cat2608 cat2608 marked this pull request as ready for review July 23, 2024 10:45
@cat2608 cat2608 requested a review from a team as a code owner July 23, 2024 10:45
@cat2608 cat2608 merged commit 381eb21 into main Jul 23, 2024
14 checks passed
@cat2608 cat2608 deleted the feat/IDE-444_retrieve-feature-flag-for-snykCodeInlineIgnore branch July 23, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants