feat: add authentication setting #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| "type": "boolean", | ||
| "markdownDescription": "Use token authentication. It is recommended to keep this turned off, as the default OAuth2 authentication is more secure.", | ||
| "scope": "window", | ||
| "default": false |
There was a problem hiding this comment.
Double-checking, but once snyk/snyk-ls#544 is merged then customers updating to the latest VSCode will need to force upgrade their snyk-ls (since it updates every 4 days) right?
There was a problem hiding this comment.
It will automatically update it, if we increase the protocol version. Probably, we should do that, right?
teodora-sandu
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
As you already know, this doesn't work without snyk/snyk-ls#544. It might be worth waiting until after Tuesday's release to merge this just so we have a bit more time for LS to be updated locally for our customers
if 'use token authentication' is set to true, oauth2 authentication is disabled
bastiandoetsch
force-pushed
the
feat/IDE-459_add-auth-setting
branch
from
2645069 to
1605894
Compare
bastiandoetsch
added a commit
that referenced
this pull request
Jul 15, 2024
This reverts commit f066c29.
bastiandoetsch
added a commit
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
if 'use token authentication' is set to true, oauth2 authentication is disabled
depends on snyk/snyk-ls#544
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!