Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: content within .suggestion is scrollable and visible [IDE-366] #479

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

cat2608
Copy link
Contributor

@cat2608 cat2608 commented Jun 25, 2024

Description

This PR fixes the issue where content within the .suggestion class was being overlapped by the footer. The overlap caused some content to be hidden, making it inaccessible.

Note:

  • The height calculation (calc(100vh - 80px)) is based on the height of the .suggestion-actions element.

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Berore

footer-suggestion-issue.mp4

After

footer-suggestion-fix.mp4

@cat2608 cat2608 requested a review from a team as a code owner June 25, 2024 07:05
@cat2608 cat2608 changed the title fix: ensure content within .suggestion is scrollable and visible fix: content within .suggestion is scrollable and visible [IDE-366] Jun 25, 2024
@cat2608 cat2608 force-pushed the fix/IDE-366-description-view branch from 73759ee to 12da64a Compare June 25, 2024 13:08
@cat2608 cat2608 force-pushed the fix/IDE-366-description-view branch from 12da64a to b64fc64 Compare June 26, 2024 08:41
@cat2608 cat2608 enabled auto-merge (squash) June 26, 2024 08:42
@cat2608 cat2608 force-pushed the fix/IDE-366-description-view branch from b64fc64 to 455eccb Compare June 26, 2024 10:18
@cat2608 cat2608 merged commit cdcbbd3 into main Jun 26, 2024
10 checks passed
@cat2608 cat2608 deleted the fix/IDE-366-description-view branch June 26, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants