fix: use fspath to get correct path [IDE-398] #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastiandoetsch
approved these changes
Jun 11, 2024
|
Nice find! |
ShawkyZ
force-pushed
the
fix/codewebviewpath-windows
branch
from
36b5426 to
715d2b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Mac/Linux there is no difference in the result between both but on Windows:
fspath returns:
'c:\\Users\\user\\work\\vscode-extension\\media\\views\\snykCode\\suggestion\\suggestionLS.css'path returns:
/c:/Users/shawky/work/vscode-extension/media/views/snykCode/suggestion/suggestionLS.cssChecklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!