Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove codeclient dependancy [IDE-364] #468

Merged
merged 8 commits into from
Jun 10, 2024
Merged

refactor: remove codeclient dependancy [IDE-364] #468

merged 8 commits into from
Jun 10, 2024

Conversation

ShawkyZ
Copy link
Contributor

@ShawkyZ ShawkyZ commented Jun 10, 2024 •
edited
Loading

Description

  • Removed snyk/code-client dependency

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@ShawkyZ ShawkyZ requested a review from a team as a code owner June 10, 2024 08:07
@ShawkyZ ShawkyZ marked this pull request as draft June 10, 2024 08:11
@ShawkyZ ShawkyZ marked this pull request as ready for review June 10, 2024 08:48
teodora-sandu
teodora-sandu reviewed Jun 10, 2024
View reviewed changes
Copy link
Contributor

@teodora-sandu teodora-sandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command doesn't work anymore so I've left a comment with what I think the issue is. Could you please add a CHANGELOG and also change the commit message to a refactor, since chores are not meant to change any of the code running for customers.

@ShawkyZ ShawkyZ changed the title chore: remove codeclient dependency [IDE-364] refactor: remove codeclient dependency [IDE-364] Jun 10, 2024
@ShawkyZ ShawkyZ changed the title refactor: remove codeclient dependency [IDE-364] refactor: remove codeclient dependancy [IDE-364] Jun 10, 2024
@ShawkyZ ShawkyZ merged commit 1b3bde0 into main Jun 10, 2024
7 checks passed
@ShawkyZ ShawkyZ deleted the chore/remove-codeclient branch June 10, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teodora-sandu teodora-sandu teodora-sandu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShawkyZ @teodora-sandu